fix: do not use trace object during processTraceDecisions #1423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Since we have delayed trace decision publication and sending a trace,
processTraceDecisions
may be processing the same trace assendTraces
which causes concurrent access to thespan.Data
map.This PR changes the
processTraceDecisions
to get trace decision information only from theTraceDecision
object and only record a trace decision if it doesn't exist in the decision cacheShort description of the changes
cache.KeptTrace
interface forTraceDecision