Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add GRPC configuration option, rework grpc config a bit #917

Merged
merged 2 commits into from
Nov 30, 2023
Merged

feat: Add GRPC configuration option, rework grpc config a bit #917

merged 2 commits into from
Nov 30, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Adds two new GRPC config values that control the max size of send and receive blocks
  • GRPC had a lot of helper functions; this eliminates most of them in favor of returning a config block
  • Documents the new parameters
  • Fixes a validation bug for memorysize related issues

@kentquirk kentquirk requested a review from a team as a code owner November 30, 2023 20:47
VinozzZ
VinozzZ reviewed Nov 30, 2023
View reviewed changes
config/config_test.go Outdated Show resolved Hide resolved
config/metadata/configMeta.yaml Show resolved Hide resolved
@kentquirk kentquirk merged commit d5be28c into main Nov 30, 2023
3 checks passed
@kentquirk kentquirk deleted the kent.905 branch November 30, 2023 21:27
@kentquirk kentquirk mentioned this pull request Dec 1, 2023
Merged
kentquirk added a commit that referenced this pull request Dec 1, 2023
@kentquirk
fix: default values in new config parameters (#925)
b4af2c7 
## Which problem is this PR solving?

- While testing the stuff in #917 I changed some default values
incorrectly.

## Short description of the changes

- Fix defaults
- Add extra conditions to the default testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we have configuration to define GRPCMessageSizeMax?
2 participants
@kentquirk @VinozzZ