-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superseded: Feature: show power grid usage on display #644
Conversation
if the power meter is enabled, the display will use every third of every three-second time slot to show the grid consumption. closes hoylabs#620.
Thanks for your effort. That the power meter on oled gets into the main firmware :) if I get you right, the powermeter value is displayed for 3s within every 9s time frame, right? On the other hand, total production, which changes way slower and isn’t that interesting / important over the day, is shown 6 seconds out of every 9. Would it be possible and wouldn’t it be more useful to visualize inverter production and grid consumption on the same view and total production on the third Slot? I guess such a change would make it more difficult to keep up with upstream changes, as the oled isn’t an onBattery exclusive feature, right? |
Yes
Hm... That's a valid point. I guess that would work for German "Netz:" and English "Grid:" as the label, but French will make trouble with "Reseau:" (too long). We can try.
Maybe. Probably? We would need to nuke the respective line only and re-draw it. Maybe that's possible. The current approach is much easier to maintain, as we nuke the whole display and have it for ourselves, without code duplication or changes to the existing code, it only adds a new code block. We could mask printing the third line with an added if-statement and without indenting the masked upstream code. That might make it easy enough to maintain. I will check. Setting this PR to draft status until then. |
i would say, give it a try. |
First of all: thank you very much! That looks very good! Best regards! |
Superseded by #658. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
if the power meter is enabled, the display will use every third of every three-second time slot to show the grid consumption.
closes #620.