Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superseded: Feature: show power grid usage on display #644

Closed

Conversation

schlimmchen
Copy link
Member

if the power meter is enabled, the display will use every third of every three-second time slot to show the grid consumption.

closes #620.

grid_display

if the power meter is enabled, the display will use every third of
every three-second time slot to show the grid consumption.

closes hoylabs#620.
@spcqike
Copy link

spcqike commented Feb 8, 2024

Thanks for your effort. That the power meter on oled gets into the main firmware :)

if I get you right, the powermeter value is displayed for 3s within every 9s time frame, right?

On the other hand, total production, which changes way slower and isn’t that interesting / important over the day, is shown 6 seconds out of every 9.

Would it be possible and wouldn’t it be more useful to visualize inverter production and grid consumption on the same view and total production on the third Slot?

I guess such a change would make it more difficult to keep up with upstream changes, as the oled isn’t an onBattery exclusive feature, right?

@schlimmchen
Copy link
Member Author

if I get you right, the powermeter value is displayed for 3s within every 9s time frame, right?

Yes

Would it be possible and wouldn’t it be more useful to visualize inverter production and grid consumption on the same view and total production on the third Slot?

Hm... That's a valid point. I guess that would work for German "Netz:" and English "Grid:" as the label, but French will make trouble with "Reseau:" (too long). We can try.

I guess such a change would make it more difficult to keep up with upstream changes, as the oled isn’t an onBattery exclusive feature, right?

Maybe. Probably? We would need to nuke the respective line only and re-draw it. Maybe that's possible. The current approach is much easier to maintain, as we nuke the whole display and have it for ourselves, without code duplication or changes to the existing code, it only adds a new code block. We could mask printing the third line with an added if-statement and without indenting the masked upstream code. That might make it easy enough to maintain.

I will check. Setting this PR to draft status until then.

@schlimmchen schlimmchen marked this pull request as draft February 8, 2024 09:58
@spcqike
Copy link

spcqike commented Feb 8, 2024

but French will make trouble with "Reseau:" (too long). We can try.

i would say, give it a try.
the third line "total:0.0kWh" now has 12 chars and it can easily display "total:250.3kWh", so 14chars.
"Reseau: 0W" would be 10 chars. so "Reseau:-999W" with 12chars should be possible. and "Reseau: 99.9kW" with 14chars should be possible, too. (i guess, "Reseau:-99.9kW" with 14 chars is possible, too, but not usefull. so one could add another decimal for values < 10kW, could one? like "Reseau: 2.56kW"

@thinklerde
Copy link

thinklerde commented Feb 9, 2024

First of all: thank you very much! That looks very good!
In terms of layout, I would suggest current production and Grid on one page. And on the next page daily yield and total yield.

Best regards!

@schlimmchen schlimmchen changed the title Feature: show power grid usage on display Superseded: Feature: show power grid usage on display Feb 10, 2024
@schlimmchen
Copy link
Member Author

Superseded by #658.

@schlimmchen schlimmchen deleted the grid-usage-on-display branch February 10, 2024 11:08
Copy link

github-actions bot commented Apr 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants