Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support configuring inverters with hex digits in serial #758

Closed
wants to merge 1 commit into from

Conversation

schlimmchen
Copy link
Member

@schlimmchen schlimmchen commented Mar 15, 2024

even though the underlying radio communication should be able to handle any inverter serial, since it is converted to uint64_t, the web application and the respective API handlers in the firmware were not yet ready to accept inverter serial numbers with actual hex digits (a-f) in them.

See #757.

even though the underlying radio communication should be able to handle
any inverter serial, since it is converted to uint64_t, the web
application and the respective API handlers in the firmware were not yet
ready to accept inverter serial numbers with actual hex digits (a-f) in
them.
@schlimmchen schlimmchen force-pushed the support-hex-inverter-serial branch from 85bf9cb to 3d96405 Compare March 15, 2024 10:22
@schlimmchen schlimmchen changed the title Fix: support configuring inverters with hex serial Fix: support configuring inverters with hex digits in serial Mar 15, 2024
@schlimmchen
Copy link
Member Author

Created a PR against the upstream project in tbnobody#1834, but Thomas says he already implemented similar code changes. So I guess we will wait for his changes to be released and have a respective fix when merging the upstream.

@schlimmchen
Copy link
Member Author

Superseded by a0d0aec and f995287 and 77b38df, which will be merged from upstream.

@schlimmchen schlimmchen deleted the support-hex-inverter-serial branch April 16, 2024 16:15
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant