Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake dataset generation #103

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fake dataset generation #103

wants to merge 5 commits into from

Conversation

joshop
Copy link

@joshop joshop commented Jul 14, 2023

No description provided.

self.total_nodes = 1
self.parent = None

def grow_inc_time(self, time):
Copy link
Collaborator

@adityaranjan adityaranjan Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that a lot of these are "internal" functions. Unless there is a use case that you see, I don't think we should expose these and can instead make them "private" by prepending them with double underscores.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll make this and the other code changes tomorrow.

@bhatele bhatele mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants