Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pull request search from issue; extend with filters #1693

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d9c5958
Split pull request search from issue; extend with filters
kgromov Aug 11, 2023
e145af8
Apply spotless updates
bitwiseman Aug 16, 2023
eec7479
Merge branch 'main' into feature/extend-pull-requests-query-search
bitwiseman Aug 16, 2023
bdc3866
Apply suggestions from code review
bitwiseman Aug 16, 2023
4d02a3c
Update src/main/java/org/kohsuke/github/GHPullRequestSearchBuilder.java
bitwiseman Aug 17, 2023
321b6ea
Update src/test/java/org/kohsuke/github/GHRepositoryTest.java
bitwiseman Aug 17, 2023
8b59aa4
Update src/test/java/org/kohsuke/github/AppTest.java
bitwiseman Aug 17, 2023
c355a14
Update snapshots fot GHRepository#testPullRequestSearch and AppTest#t…
kgromov Aug 22, 2023
02325be
Merge branch 'main' into feature/extend-pull-requests-query-search
bitwiseman Aug 24, 2023
e933b4c
Change target to wiremock files explicitly to custom repo
kgromov Aug 25, 2023
7d8ca89
Fix creationDate timezone issue for test data
kgromov Aug 25, 2023
f2c5149
Update CONTRIBUTING.md with small tips for snapshots taken from perso…
kgromov Aug 25, 2023
9e03957
Fix created search param caused by timezone diff
kgromov Aug 27, 2023
74f407a
Fix code coverage
kgromov Aug 31, 2023
7c98382
Cover pull request search builder more than 90%
kgromov Sep 12, 2023
4c613ba
Merge branch 'main' into feature/extend-pull-requests-query-search
kgromov Sep 12, 2023
dc0a8fa
Fix for java 8 build - remove factory method for Set
kgromov Sep 14, 2023
ea17ade
Merge branch 'main' into feature/extend-pull-requests-query-search
bitwiseman Oct 20, 2023
e0cb1b2
Merge branch 'main' into feature/extend-pull-requests-query-search
kgromov Nov 10, 2023
8d9b194
Change GHRepository#searchPullRequests to return buider
kgromov Nov 11, 2023
0859587
Merge branch 'main' into feature/extend-pull-requests-query-search
kgromov Nov 11, 2023
a82c15e
Rollback optimimzation for unique search terms to satisfy japicmp typ…
kgromov Nov 12, 2023
586f89e
Remove extra constructor from GHPullRequestSearchBuilder
bitwiseman Nov 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ a Java VM option). For example:
The above command will create snapshot WireMock data files under the path `src/test/resources/org/kohsuhke/github/YourTestClassName/wiremock`.
Each method will get a separate directory that will hold the data files for that test method.

*Note:* if you are using personal github account don't forget to change `getTempRepository()` to `gitHub.getRepository("${your_account}/${test_method_name}")`
in order to match with snapshot file name for wiremock. To double-check run test without `-Dtest.github.org=false` flag after snapshot is saved.

Add all files including the generated data to your commit and submit a PR.

### Modifying existing tests
Expand Down
Loading