type WidgetExampleAttribute
#1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBrandeis
approved these changes
Oct 30, 2023
| @@ -32,7 +31,7 @@ | |||
| export let outputJson: string; | |||
| export let applyInputSample: (sample: TWidgetExample, opts?: ExampleRunOpts) => void = () => {}; | |||
| export let validateExample: (sample: WidgetExample) => sample is TWidgetExample; | |||
| export let exampleQueryParams: QueryParam[] = []; | |||
| export let exampleQueryParams: WidgetExampleAttribute[] = []; | |||
There was a problem hiding this comment.
It would be even better if the type was tied to the concrete TWidgetExample
| @@ -108,3 +108,7 @@ export type WidgetExample<TOutput = WidgetExampleOutput> = | |||
| | WidgetExampleTableDataInput<TOutput> | |||
| | WidgetExampleZeroShotTextInput<TOutput> | |||
| | WidgetExampleSentenceSimilarityInput<TOutput>; | |||
|
|
|||
| type KeysOfUnion<T> = T extends any ? keyof T : never; | |||
There was a problem hiding this comment.
Isn't this just keyof T?
There was a problem hiding this comment.
they are different. In keyof T case, ts errs
|
merging it now. Might make the typing even stronger in subseq PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1023
This PR renames some typing to be more clear. Check out the files tab