Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget docs] Add screenshots for examples outputs #1076

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Nov 2, 2023

Follow up to this comment, #978

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 2, 2023

The documentation is not available anymore as the PR was closed or merged.

@mishig25 mishig25 merged commit f37c2bc into main Nov 2, 2023
1 check passed
@mishig25 mishig25 deleted the widget_outputs_imgs branch November 2, 2023 15:19
@julien-c
Copy link
Member

julien-c commented Nov 2, 2023

ah i meant more like a screenshot of the gallery inside model card

@mishig25
Copy link
Collaborator Author

mishig25 commented Nov 2, 2023

ah i meant more like a screenshot of the gallery inside model card

Are you referring to <Gallery> component @krampstudio developing inside moon ? If that is the case, I think this PR (adding images for widget outputs) doesn't hurt and we still have the todo

We can also surface the example outputs in the Hugging Face UI, for instance, for a text-to-image model to display a gallery of cool image generations.
<!-- todo(add a screenshot) -->

or do you mean that we should update the text2img widget to have gallery like view?

@julien-c
Copy link
Member

julien-c commented Nov 2, 2023

Are you referring to <Gallery> component @krampstudio developing inside moon ? If that is the case, I think this PR (adding images for widget outputs) doesn't hurt and we still have the todo

yes, but just a mockup we already have

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

^this is supposed to be text-classification

image

^this is supposed to be ASR

@mishig25
Copy link
Collaborator Author

mishig25 commented Nov 2, 2023

Fixed them with #1078

Initially, I wanted to have screenshots that only share output (not the input) with the code blocks above the screenshots to show users all kinds of different widget types. But I see that it can be quite confusing

Updated ss

https://huggingface.co/docs/hub/models-widgets#example-outputs

image image

@mishig25
Copy link
Collaborator Author

mishig25 commented Nov 3, 2023

regarding this comment, added screenshot from figma spec as well in #1079

https://huggingface.co/docs/hub/models-widgets#example-outputs

image

@julien-c
Copy link
Member

julien-c commented Nov 3, 2023

yes, looks good^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants