Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show image that introduces concept of splits/configs #1215

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Conversation

severo
Copy link
Collaborator

@severo severo commented Feb 9, 2024

Adds the gif:

Enregistrement.de.l.ecran.2024-02-09.a.12.42.28.mov

also: fixes #1212 -> https://moon-ci-docs.huggingface.co/docs/hub/pr_1215/en/datasets-viewer. Is it too much?

Capture d’écran 2024-02-09 à 12 41 56

@severo severo requested review from lhoestq and stevhliu February 9, 2024 11:28
@HuggingFaceDocBuilderDev

It looks like you've updated documentation related to model or dataset cards in this PR.

Some content is duplicated among the following files. Please make sure that everything stays consistent.

@severo
Copy link
Collaborator Author

severo commented Feb 9, 2024

ok bot. I just fixed a broken link.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the gif does a nice job of visually explaining it so I don't think it's too much :)

docs/hub/datasets-data-files-configuration.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer.md Show resolved Hide resolved
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe related: you could add a section with a screenshot of parquet-converter profile so it gives it "legitimacy"

image

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the gif :)

docs/hub/datasets-data-files-configuration.md Outdated Show resolved Hide resolved
@severo
Copy link
Collaborator Author

severo commented Feb 12, 2024

you could add a section with a screenshot of parquet-converter profile so it gives it "legitimacy"

done

@severo severo merged commit af6134e into main Feb 12, 2024
2 checks passed
@severo severo deleted the show-splits-image branch February 12, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Parquet advantages in dataset viewer docs
5 participants