Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use base_model to encode that a model is a quantized version of another model #1254

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

julien-c
Copy link
Member

@julien-c julien-c commented Mar 22, 2024

screenshots

base_model_quantized base_model_quantized-dark

Credits

idea from @PrithivirajDamodaran

@HuggingFaceDocBuilderDev

It looks like you've updated documentation related to model or dataset cards in this PR.

Some content is duplicated among the following files. Please make sure that everything stays consistent.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@davanstrien davanstrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-c julien-c requested a review from davanstrien March 22, 2024 19:15
@julien-c
Copy link
Member Author

re-requesting review @davanstrien as i added some screenshots to the doc page (maybe it's too much?)

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

<div class="flex justify-center">
<img class="block dark:hidden" src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/hub/base_model_quantized.png"/>
<img class="hidden dark:block" src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/hub/base_model_quantized-dark.png"/>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for so many images imo, just showing fine-tuned and merge might be fine (for merge I would also show a yaml example with two base models)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quantized is important too no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me add the yaml example with two base models

docs/hub/peft.md Show resolved Hide resolved
docs/hub/model-cards.md Outdated Show resolved Hide resolved
@julien-c
Copy link
Member Author

Thanks for your reviews, merging!

@julien-c julien-c merged commit 92283a3 into main Mar 29, 2024
2 checks passed
@julien-c julien-c deleted the use-base-model-for-quantized-models branch March 29, 2024 11:57
@julien-c
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants