Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sql console section #1434

Merged
merged 18 commits into from
Sep 27, 2024
Merged

add sql console section #1434

merged 18 commits into from
Sep 27, 2024

Conversation

cfahlgren1
Copy link
Contributor

@cfahlgren1 cfahlgren1 commented Sep 26, 2024

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@cfahlgren1 cfahlgren1 force-pushed the add-sql-console branch 3 times, most recently from fb79959 to 090ea15 Compare September 26, 2024 17:09
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! It's still a bit empty, I added a comment of content that could be useful (happy to help on this if needed)

docs/hub/_toctree.yml Outdated Show resolved Hide resolved
docs/hub/datasets-viewer-sql-console.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer-sql-console.md Show resolved Hide resolved
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool!

docs/hub/datasets-viewer.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer-sql-console.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer.md Outdated Show resolved Hide resolved
docs/hub/__pycache__/_config.cpython-312.pyc Outdated Show resolved Hide resolved
@cfahlgren1
Copy link
Contributor Author

I put back the more verbose h1 so the seo title is better, but open to change

image

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added my final comments, otherwise lgtm :)

docs/hub/datasets-viewer-sql-console.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer-sql-console.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer-sql-console.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer-sql-console.md Outdated Show resolved Hide resolved
docs/hub/datasets-viewer-sql-console.md Outdated Show resolved Hide resolved
@cfahlgren1 cfahlgren1 merged commit 59d3159 into main Sep 27, 2024
2 checks passed
@cfahlgren1 cfahlgren1 deleted the add-sql-console branch September 27, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants