Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ollama tweaks #1448

Merged
merged 3 commits into from
Oct 16, 2024
Merged

ollama tweaks #1448

merged 3 commits into from
Oct 16, 2024

Conversation

julien-c
Copy link
Member

No description provided.

@julien-c julien-c requested review from ngxson and Vaibhavs10 October 16, 2024 11:06
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Vaibhavs10
Vaibhavs10 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This reads much, much better!

pcuenca
pcuenca approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Additional, optional nits I saw while reading it:

  • Line 15: Here are some models you can try (remove other)
  • Line 64: To know more about the Go template format (adding the)

@Vaibhavs10
Copy link
Member

Should we also take care of this here: #1447 (comment)

@ngxson
Copy link
Member

ngxson commented Oct 16, 2024

@Vaibhavs10 yup, done 6a22bbf

@julien-c
Copy link
Member Author

ok, merging!

@julien-c julien-c merged commit 6a102ac into main Oct 16, 2024
2 checks passed
@julien-c julien-c deleted the ollama-tweaks branch October 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vaibhavs10 Vaibhavs10 Vaibhavs10 approved these changes

@ngxson ngxson ngxson approved these changes

@pcuenca pcuenca pcuenca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julien-c @HuggingFaceDocBuilderDev @Vaibhavs10 @ngxson @pcuenca