Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd llama.cpp docs #1580

Merged
merged 3 commits into from
Jan 17, 2025
Merged

upd llama.cpp docs #1580

merged 3 commits into from
Jan 17, 2025

Conversation

Vaibhavs10
Copy link
Member

@Vaibhavs10 Vaibhavs10 commented Jan 17, 2025 •
edited
Loading

@Vaibhavs10 Vaibhavs10 requested review from ngxson and julien-c January 17, 2025 14:23
julien-c
julien-c approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think maybe the -cnv is not required anymore but i'll let @ngxson review too

@ngxson
Copy link
Member

ngxson commented Jan 17, 2025

Yup, the whold line -p "You are a helpful assistant" -cnv is no longer required. The command can now be one-liner

ngxson
ngxson reviewed Jan 17, 2025
View reviewed changes
docs/hub/gguf-llamacpp.md Outdated Show resolved Hide resolved
pcuenca
pcuenca approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Vaibhavs10 Vaibhavs10 merged commit 3dd77f3 into main Jan 17, 2025
2 checks passed
@Vaibhavs10 Vaibhavs10 deleted the vb/upd-llama-cpp branch January 17, 2025 15:16
@ngxson
Copy link
Member

ngxson commented Jan 17, 2025

Nice, thanks @Vaibhavs10 !! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson left review comments

@pcuenca pcuenca pcuenca approved these changes

@julien-c julien-c julien-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vaibhavs10 @ngxson @julien-c @pcuenca