Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inference] [Providers] Enforce task in mapping + expose them #1109

Merged
merged 8 commits into from
Jan 17, 2025
Merged

[Inference] [Providers] Enforce task in mapping + expose them #1109

merged 8 commits into from
Jan 17, 2025

Conversation

SBrandeis
Copy link
Contributor

@SBrandeis SBrandeis commented Jan 16, 2025 •
edited
Loading

TL;DR

  • Add task metadata to the HF id -> Provider id mappings, to forbid the usage of a chat model with the textToImage inference function for example
  • Expose the supported models mappings in index.ts

@SBrandeis SBrandeis changed the title [Inference] [Providers] Enforce task mapping [Inference] [Providers] Enforce task in mapping Jan 16, 2025
@SBrandeis SBrandeis marked this pull request as ready for review January 16, 2025 16:51
@SBrandeis SBrandeis changed the title [Inference] [Providers] Enforce task in mapping [Inference] [Providers] Enforce task in mapping + expose them Jan 16, 2025
@Pierrci
Copy link
Member

Pierrci commented Jan 16, 2025

lgtm

@SBrandeis SBrandeis mentioned this pull request Jan 17, 2025
Draft
3 tasks
@SBrandeis SBrandeis merged commit f1fe42c into main Jan 17, 2025
5 checks passed
@SBrandeis SBrandeis deleted the inference/providers-task-mapping branch January 17, 2025 14:18
julien-c
julien-c reviewed Jan 17, 2025
View reviewed changes
packages/inference/src/index.ts
Comment on lines +3 to +6
export { FAL_AI_SUPPORTED_MODEL_IDS } from "./providers/fal-ai";
export { REPLICATE_SUPPORTED_MODEL_IDS } from "./providers/replicate";
export { SAMBANOVA_SUPPORTED_MODEL_IDS } from "./providers/sambanova";
export { TOGETHER_SUPPORTED_MODEL_IDS } from "./providers/together";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for moon's consumption, i presume?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c left review comments

@coyotte508 coyotte508 coyotte508 approved these changes

@Pierrci Pierrci Awaiting requested review from Pierrci

@Wauplin Wauplin Awaiting requested review from Wauplin

@hanouticelina hanouticelina Awaiting requested review from hanouticelina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SBrandeis @Pierrci @julien-c @coyotte508