Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Tasks] Add typings for the TGI / OpenAI chat API #480

Closed
wants to merge 10 commits into from

Conversation

SBrandeis
Copy link
Contributor

@SBrandeis SBrandeis commented Feb 9, 2024

@SBrandeis SBrandeis force-pushed the text-generation-messages-api branch from ad00ad5 to 537e06b Compare February 9, 2024 16:32
@SBrandeis SBrandeis changed the title Add typings for the TGI / OpenAI chat API ✨ [Tasks] Add typings for the TGI / OpenAI chat API Feb 9, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the types very different from the "classic" mode?

(if not, maybe we could embed them in the same task?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not a huge fan of the name text-generation-conversational, would prefer text-generation-messages-api in that case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the types very different from the "classic" mode?

Sadly looks quite different from our text-generation. Our types are all based on a dict with inputs and parameters. Here parameters seem to be at the root level instead of a level below. And inputs (simple string) is replaced by the messages list of items.
Merging both specs doesn't seem to have conflicting keys but would result in a quite ugly definition no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then let's go imo

Base automatically changed from add-missing-generate-params to main February 12, 2024 11:01
@SBrandeis
Copy link
Contributor Author

Closing in favor of #537

@SBrandeis SBrandeis closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants