-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Tasks] Add typings for the TGI / OpenAI chat API #480
Conversation
ad00ad5
to
537e06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the types very different from the "classic" mode?
(if not, maybe we could embed them in the same task?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also not a huge fan of the name text-generation-conversational
, would prefer text-generation-messages-api
in that case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the types very different from the "classic" mode?
Sadly looks quite different from our text-generation
. Our types are all based on a dict with inputs
and parameters
. Here parameters seem to be at the root level instead of a level below. And inputs
(simple string) is replaced by the messages
list of items.
Merging both specs doesn't seem to have conflicting keys but would result in a quite ugly definition no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then let's go imo
Closing in favor of #537 |
Ping @julien-c @Wauplin @osanseviero
parameters from https://huggingface.github.io/text-generation-inference/#/Text%20Generation%20Inference/chat_completions