Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of the quick tour. #501

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve readability of the quick tour. #501

wants to merge 1 commit into from

Conversation

vxw3t8fhjsdkghvbdifuk
Copy link
Contributor

No description provided.

@vxw3t8fhjsdkghvbdifuk
Copy link
Contributor Author

vxw3t8fhjsdkghvbdifuk commented Jan 14, 2025 •
edited
Loading

Actually, I'm not sure running 2 models at the same time is true. When I run

lighteval accelerate \
"pretrained=HuggingFaceTB/SmolLM2-135M-Instruct,pretrained=HuggingFaceTB/SmolLM2-360M-Instruct" \
"leaderboard|truthfulqa:mc|0|0"

it only evaluates the second model. It seems the code doc in

lighteval/src/lighteval/main_accelerate.py

Line 47 in a7aa6ed

help="Model arguments in the form key1=value1,key2=value2,... or path to yaml config file (see examples/model_configs/transformers_model.yaml)"
is not correct?

clefourrier
clefourrier reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the doc you're referring to, you can see that the keys are not the same - you cannot evaluate 2 models at the same time, but you can specify a range of parameters to use for one model however

docs/source/quicktour.mdx

Tasks details can be found in the
All supported tasks can be found at the [tasks_list](available-tasks). For more details, you can have a look at the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also support the tasks that are community provided in the extended folder

docs/source/quicktour.mdx
the [tasks_list](available-tasks) in the format:
Here, the first argument specifies which model(s) to run, and the second argument specifies how to evaluate them.

Multiple models can be evaluated at the same time by using a comma-separated list. For example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we can only evaluate one model at a time - however we can specifiy precision, peft weights, ...

docs/source/quicktour.mdx
The task specification might be a bit hard to grasp as first. The format is as follows:

```bash
{suite}|{task}|{num_few_shot}|{0 or 1 to automatically reduce `num_few_shot` if prompt is too long}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatically adapt the number of few shot examples presented to the model if the prompt is too long for the context size of the task or the model

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I would add this explanation on antoher line)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clefourrier clefourrier clefourrier left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vxw3t8fhjsdkghvbdifuk @clefourrier