BUG FIX Tool Argument Parsing Error #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on serializable format. It also parses arguments to tool calls.
…do not get parsed as dict but as str and are treated as a single argument leading to error.
… were not getting parsed from string into dict.
…bl/smolagents into tool_parsing_error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this bug, tools that use more than a single argument failed when executed. Reason was that argument were not correctly parsed into
Dictand treated as a singlestrargument inagent.py.An example of the error message is below (this is raised despite the agent correctly passing a value for
celsius:Error in tool call execution: get_weather() missing 1 required positional argument: 'celsius' You should only use this tool with a correct input.Note: I see there is a second pull request solving the same bug but I think this solution might be cleaner.