Add RemBERT ONNX config #20520
Merged
Add RemBERT ONNX config #20520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2022 21:36
|
The documentation is not available anymore as the PR was closed or merged. |
chainyo
suggested changes
Dec 1, 2022
There was a problem hiding this comment.
Hi @hchings, the PR looks excellent! Did you try to run tests locally?
RUN_SLOW=1 pytest tests/onnx/test_onnx_v2.py -k "rembert"
Could you also remove the Fixes #... before the link to the ONNX issue to avoid an auto-close from GitHub? Thanks a lot for your contribution!
Yes, all slow tests passed for PyTorch locally. Should we add TensorFlow tests as well? My understanding is TF tests are needed only when TF has parity with PyTorch implementations. But correct me if I'm wrong. |
sgugger
approved these changes
Dec 5, 2022
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Dec 7, 2022
* rembert onnx config * formatting Co-authored-by: Ho <[email protected]>
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* rembert onnx config * formatting Co-authored-by: Ho <[email protected]>
venkat-natchi
pushed a commit
to venkat-natchi/transformers
that referenced
this pull request
Jan 22, 2023
* rembert onnx config * formatting Co-authored-by: Ho <[email protected]>
miyu386
pushed a commit
to miyu386/transformers
that referenced
this pull request
Feb 9, 2023
* rembert onnx config * formatting Co-authored-by: Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add RemBERT ONNX config (part of #16308)
The max absolute difference between reference model and ONNX exported model is around
2e-05in testings. I learned from other PRs that this discrepancy is within an acceptable range so I loosen the default atol.Slow tests are passed (
RUN_SLOW=1 pytest tests/onnx/test_onnx_v2.py -k "rembert").I'm new to contributing to Transformers. If anyone can help me understand what is lacking, it would be appreciated!
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@lewtun & @chainyo for ONNX and @Iwontbecreative for RemBERT.