Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket error message on Firefox #1687

Closed
wants to merge 2 commits into from

Conversation

kuba-orlik
Copy link

@kuba-orlik kuba-orlik commented Jan 22, 2024

Should fix #1674

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@Lord-Grey
Copy link
Collaborator

@kuba-orlik Thanks for taking the time providing a PR!
In the meantime, I had a look at the issue and I think the overall way communicating with Kodi needs to be reworked.
Currently, for every command a new WebSocket is established rather one reused during calibration.
The current code is a 1:1 conversion from http calls to WebSocket given at http was not possible due to CORS any longer.

I already started on it and will share when ready for your feedback.

PS: In addition , it would be good opening a issue a Kodi, as it seems Kodi does not handle the WebSocket close correctly.
When I just put a simple Python server instead of Kodi, the code works.

@Lord-Grey Lord-Grey closed this Mar 23, 2024
@Lord-Grey
Copy link
Collaborator

Lord-Grey commented Mar 23, 2024

Closed PR due to refactoring via #1718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color calibration via Kodi doesn't work
2 participants