Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1722 - hyperion-v4l2 taking screenshot failed #1723

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

Lord-Grey
Copy link
Collaborator

Summary

Fixes

  • hyperion-v4l2 taking screenshot failed

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Fixes #1722

@Lord-Grey Lord-Grey added the Bug label Apr 13, 2024
@Lord-Grey Lord-Grey self-assigned this Apr 13, 2024
@Lord-Grey Lord-Grey merged commit c2fe42a into hyperion-project:master Apr 13, 2024
18 checks passed
@Thinner77
Copy link
Contributor

Hi,

can you fix indent, please? (tabs not spaces)

wbr

@Lord-Grey
Copy link
Collaborator Author

Lord-Grey commented May 3, 2024

Hi,

can you fix indent, please? (tabs not spaces)

wbr

Thanks for highlighting. I will have this corrected.
I had some issues with the IDE before and I did not realize when finalizing the PR :)

@Lord-Grey Lord-Grey deleted the #1722 branch May 20, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

hyperion-v4l2: taking screenshot results in memory access error
3 participants