Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revise NonZeros #5278

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: revise NonZeros #5278

wants to merge 1 commit into from

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Jan 8, 2025

Context

Solution

  • Fix misdefined NonZeroU64 to u64

Checklist

  • I've read CONTRIBUTING.md.
  • All review comments have been resolved.
  • All CI checks pass.

@s8sato
fix: revise NonZeros
81c47b8 
Signed-off-by: Shunkichi Sato <[email protected]>
@s8sato s8sato self-assigned this Jan 8, 2025
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Jan 8, 2025
@s8sato s8sato mentioned this pull request Jan 8, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 approved these changes

@mversic mversic Awaiting requested review from mversic mversic will be requested when the pull request is marked ready for review mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith will be requested when the pull request is marked ready for review SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis will be requested when the pull request is marked ready for review outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 will be requested when the pull request is marked ready for review DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 will be requested when the pull request is marked ready for review dima74 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@s8sato s8sato

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s8sato @0x009922