Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port identifier validation and add tests #288

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

bluele
Copy link
Member

@bluele bluele commented Jul 23, 2024

Fix #287

bluele added 2 commits July 23, 2024 10:55
* add port identifier validation test from ibc-go

Signed-off-by: Jun Kimura <[email protected]>
@bluele bluele force-pushed the fix-port-identifier-validation branch from 5593b60 to 18c7639 Compare July 23, 2024 01:55
@bluele bluele marked this pull request as ready for review July 23, 2024 02:10
@bluele bluele requested a review from a team as a code owner July 23, 2024 02:10
@bluele bluele merged commit 138814b into main Jul 23, 2024
5 checks passed
@bluele bluele deleted the fix-port-identifier-validation branch July 23, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validatePortIdentifier doesn't return false
1 participant