Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC-8: Fix missing checks on revision_number #310

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

bluele
Copy link
Member

@bluele bluele commented Nov 25, 2024

No description provided.

@bluele bluele added the audit label Nov 25, 2024
@bluele bluele force-pushed the audit-202409-ibc-8 branch 5 times, most recently from 08c0139 to 3a6e4e3 Compare November 26, 2024 02:15
@siburu
Copy link
Contributor

siburu commented Nov 26, 2024

@bluele In many files under the contracts/clients directory, revision_number is initialized to or compared to hardcoded 0s.
Shouldn't these 0s be replaced with DEFAULT_REVISION_NUMBER?

@bluele
Copy link
Member Author

bluele commented Nov 29, 2024

Thanks. I think your point is valid for LocalhostClient. In practice, revision_number is always expected to be 0, so probably there is no issue. However, it might still be worth refactoring. To enable this, I’ve added getRevisionNumber() function to the IIBCQuerier.
Since the clients/ directory is outside the scope of the current audit, I’ll consider making this change in the future.

@bluele bluele force-pushed the audit-202409-ibc-8 branch from 3a6e4e3 to ba1ce2b Compare November 29, 2024 09:05
@bluele bluele marked this pull request as ready for review December 2, 2024 01:14
@bluele bluele requested a review from a team as a code owner December 2, 2024 01:14
@bluele bluele merged commit 9759e51 into audit-202409 Dec 2, 2024
6 checks passed
@bluele bluele deleted the audit-202409-ibc-8 branch December 2, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants