Fix solidity compilation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the current compiler settings in hardhat.config.ts Signed-off-by: Andrew Richardson <[email protected]>
jimthematrix
approved these changes
Jan 3, 2025
awrichar
force-pushed
the
fix-contracts
branch
from
fa64100 to
436acff
Compare
The current Zeto contracts use Array.sort(), which was added in 5.1.0. They do not compile with earlier versions of the library. Signed-off-by: Andrew Richardson <[email protected]>
awrichar
force-pushed
the
fix-contracts
branch
from
436acff to
bd056ef
Compare
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently unable to compile the Solidity contracts or unit tests, primarily due to usage of
Arrays.sort(), which isn't present in version 5.0.1 of the OpenZeppelin contracts. I think this is due to the missingpackage-lock.jsonfile, which means the npm install is unpredictable.This updates the version of the OpenZeppelin dependency to 5.1.0 and adds back the
package-lock.jsonfile, so thatArrays.sort()is available. It also aligns the Solidity version pragma with the current version in the Hardhat config.