Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of issue #1204 #1205

Closed
wants to merge 1 commit into from
Closed

Fix of issue #1204 #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test-network-k8s/scripts/prereqs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function check_prereqs() {
if [[ $? -ne 0 ]]; then
echo "Downloading LATEST Fabric binaries and config"
curl -sSL https://raw.githubusercontent.com/hyperledger/fabric/main/scripts/bootstrap.sh \
| bash -s -- -s -d
| bash -s -- ${FABRIC_VERSION} ${FABRIC_CA_VERSION} -s -d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
However, isn't FABRIC_VERSION and FABRIC_CA_VERSION a two digit number in these scripts (e.g. 2.5), whereas the bootstrap.sh script requires a three digit version for pulling binaries (e.g. 2.5.7).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually in my local copy of network script, I am using 3 digit versions. However I can define a pair of auxiliary variables in order to save both 2 digit and 3 digit version's formats in network script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be enough to make the defaults 3 digit versions? Alternatively, it might be nice if the fabric install script accepted 2 digit versions and "did the right thing" ...and it might be good to use the newer install script instead of bootstrap.sh


# remove sample config files extracted by the installation script
rm config/configtx.yaml
Expand All @@ -65,4 +65,4 @@ function check_prereqs() {
fi

set -e
}
}
Loading