-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Pollux): plugins #349
base: main
Are you sure you want to change the base?
Conversation
a6744c0
to
cfa476a
Compare
cfa476a
to
ffe2e9c
Compare
Signed-off-by: Curtish <[email protected]>
Signed-off-by: Curtish <[email protected]>
ffe2e9c
to
8769062
Compare
Signed-off-by: Curtish <[email protected]>
8769062
to
047f03d
Compare
@curtis-h The PR is pretty big and I'm going to finish the review soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes but not how much testing scenarios we have removed and some validation rules we had. Maybe not restoring anything but I propose to at least improve the test cases that we had in Pollux around the different credentials and what errors to expect
Let's split the work btw
Description:
BREAKING CHANGES:
Pollux interface complete rewrite to plugins.
Anoncreds not available by default, needs to be loaded (if wanted).
removed
Message.credentialFormat
- used AttachmentFormatsHelpers, a large number of helpers, intended for internal use but are technically exported in the Package, so listing below:
Domain.InputLimitDisclosure - specific to modules
Domain.DescriptorItemFormat - specific to modules
Domain.SDJWTVerifiableCredentialProperties - now use
JWT.Claims | SDJWT_VP_PROPS
insteadDomain.JWTVerifiableCredentialProperties - now use
JWT.Claims | JWT_VP_PROPS
insteadDomain.JWTVerifiablePresentationProperties - now use
JWT.Claims | JWT_VC_PROPS | JWT_VP_PROPS
insteadDomain.CredentialSubject
Domain.VerifiableCredentialTypeContainer
Domain.PredicateType
Domain.AttributeType
JWTPresentationClaims
SDJWTPresentationClaims
AnoncredsPresentationClaims
AnoncredsInputFieldFilter
InputFieldFilter
InputField
InputConstraints
InputDescriptor
DefinitionFormat
PresentationAnoncredsRequest
PresentationExchangeDefinitionRequest
PresentationDefinitionData
PresentationDefinitionRequestType
PresentationDefinitionRequest
DescriptorItem
JWTPresentationSubmission
SDJWTPresentationExchangeSubmission
SDJWTPresentationSubmission
AnoncredsPresentationSubmission
PresentationSubmissionData
PresentationSubmission
W3CVerifiableCredentialData
JWTRevocationStatusPurpose
CredentialStatusType
RevocationType
JWTRevocationStatus
JWTProofType
JWTProofPurpose
JWTStatusListResponse
JWTCredentialPayload
JWTPresentationPayload
Hasher
Signer
Verifier
JWTHeader
JWTPayload
PresentationJWTOptions
PresentationRequestOptions
PresentationOptions
AnoncredsPresentationOptions
SDJWPresentationOptions
JWTPresentationOptions
isPresentationDefinitionRequestType
Fixes:
Checklist: