Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some examples failing compilation #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented Jan 7, 2025

  • Fix hyprland::bind!() warnings in examples/bind.rs because the Result was not being checked
  • Fix typo in some generated methods (change => changed), I assume the macro changed at some point?
  • I also took care of some clippy warnings (2nd commit)

I noticed the bind test still fails though:

---- config::test_binds stdout ----
thread 'config::test_binds' panicked at src/config.rs:269:5:
assertion `left == right` failed
  left: "SUPER,v,togglefloating"
 right: "SUPER,v,/togglefloating"

I'm not sure what the fix would be here? Does Binder::gen_str need to be updated to include the /, or should the expected value (right) be without the /?

@yavko
Copy link
Member

yavko commented Jan 11, 2025

I'll take a look at how to fix that test in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants