deps: relocate 'c8' to devDependencies #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
changed the title
|
Ohh oops! Sorry I must have missed this one somehow! |
|
No problem! And yep - I'll take a look at resolving those conflicts (probably by regenerating the lockfile) after the weekend. |
Signed-off-by: James Addison <[email protected]>
jayaddison
force-pushed
the
dependencies/c8-to-devDependencies
branch
from
fbdfcb6 to
c82d905
Compare
|
That should be done now @perrin4869 - NB: I re-ran the tests again on the rebased version. |
|
Thanks! |
|
thank you! it's released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testtests are includedThe dependency on
c8is used when generating test coverage, and isn't required by the application or CLI at runtime; so I think we can/should move it to thedevDependenciescategory inpackage.json.