-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-9413: Corrected incorrect type, changed how to retrieve variables #62
base: 4.6
Are you sure you want to change the base?
IBX-9413: Corrected incorrect type, changed how to retrieve variables #62
Conversation
22f398f
to
8fa46ed
Compare
8fa46ed
to
407d746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I see that accelerator is indeed visible after your change, but CPU and memory is empty as before. Not sure what determines if the above is available or not.
7539f98
to
f9e2850
Compare
I tested it on 3 different devices and after the changes, the information about CPU and memory appeared correctly |
f9e2850
to
aa27328
Compare
Quality Gate passedIssues Measures |
I tested it locally (Apple M1 Pro) and it failed. 😉 I will let QA give their opinion though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to unblock QA but this PR doesn't fix the issue on my local machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apple ARM:
CPU NOK
Memory NOK
Accelerator OK
Linux in VM on Apple ARM:
CPU NOK
Memory OK
Accelerator OK
PHP 8.3.14/15/16. Tested on Linux with Apache and Nginx.
Apple Intel: Linux in VM on Apple Intel: |
FWIW, with WSL (Linux on Windows), cpu/mem/acc are all ok before and after the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary.
On Mac, regardless of architecture, only Accelerator field displays valid value. Reported separately as https://issues.ibexa.co/browse/IBX-9437.
Virtual machines with Linux on Mac:
with Intel - all 3 fields work correctly
with ARM - Memory and Accelerator work, CPU is blank.
On Platform.sh all 3 fields work correctly.
get_object_vars
- uninitialized properties are considered inaccessible, and thus will not be included in the array.If we use types for variables they are treated as uninitialized, which is why the get_object_vars function cannot retrieve them. I also don't see the point of assigning null to each variable to initialize it. During the last change, unfortunately, phpVersion was set to string instead of an array, which after fixing the problem with retrieving variables caused a new error