Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear vmthread from thread object at shutdown #679

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Clear vmthread from thread object at shutdown #679

merged 1 commit into from
Oct 27, 2023

Conversation

tajila
Copy link
Member

@tajila tajila commented Oct 23, 2023

@tajila tajila requested a review from JasonFengJ9 October 23, 2023 14:29
@tajila tajila mentioned this pull request Oct 23, 2023
Closed
@tajila
Copy link
Member Author

tajila commented Oct 23, 2023

@gacholio ^^

@tajila
Copy link
Member Author

tajila commented Oct 23, 2023

jenkins test sanity alinux64 jdknext

@JasonFengJ9
Copy link
Member

JasonFengJ9 commented Oct 23, 2023 •
edited
Loading 

10:48:03  /home/jenkins/workspace/Build_JDKnext_aarch64_linux_Personal/build/linux-aarch64-server-release/support/j9jcl/java.base/share/classes/java/lang/Access.java:69: error: Access is not abstract and does not override abstract method ensureNativeAccess(Module,Class<?>,String) in JavaLangAccess
10:48:03  final class Access implements JavaLangAccess {
10:48:03        ^
10:48:03  /home/jenkins/workspace/Build_JDKnext_aarch64_linux_Personal/build/linux-aarch64-server-release/support/j9jcl/java.base/share/classes/java/lang/Access.java:399: error: method does not override or implement a method from a supertype
10:48:03  	@Override
10:48:03  	^
10:48:03  /home/jenkins/workspace/Build_JDKnext_aarch64_linux_Personal/build/linux-aarch64-server-release/support/j9jcl/java.base/share/classes/java/lang/Access.java:401: error: method ensureNativeAccess in class Module cannot be applied to given types;
10:48:03  		mod.ensureNativeAccess(clsOwner, methodName, clsCaller);

The latest openjdk updates are still in openj9-staging branch, which is blocked by

@tajila
Copy link
Member Author

tajila commented Oct 23, 2023

Okay, Ill make a JDK21 PR

@gacholio
Copy link
Member

Yes, this looks better.

@pshipton
Copy link
Member

pshipton commented Oct 23, 2023 •
edited
Loading

The latest openjdk updates are still in openj9-staging branch, which is blocked by

It's also blocked by crash vmState=0x0005ffff building xmac jdk22

@JasonFengJ9 JasonFengJ9 mentioned this pull request Oct 24, 2023
Merged
@keithc-ca
Copy link
Member

Jenkins test sanity alinux64 jdknext

@keithc-ca
Copy link
Member

The failures are known: eclipse-openj9/openj9#18306.

@keithc-ca keithc-ca merged commit 9c8c7f0 into ibmruntimes:openj9 Oct 27, 2023
tajila pushed a commit to tajila/openj9-openjdk-jdk that referenced this pull request Mar 27, 2024
@keithc-ca
Merge pull request ibmruntimes#679 from WilburZjh/exportSecretKey
535df28 
Support exporting plain SecretKey in FIPS mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tajila @JasonFengJ9 @gacholio @pshipton @keithc-ca