Get rid of AIX linker option: -bnorwexec #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High-level: this linker option is oxymoronic with JIT environment (where executable code are generated on the fly anyway). At least for the time being before we figured out why default codeCache is allocated through malloc (instead of mmap or shmget, for which that linker option appeared to have no effect by my tests). Even after we figured it out eventually, it is a legitimate question what value this option provides for JIT environment. this also has effect on FFI thunks (which are not generated in JIT codecache). Issue ibmruntimes#162
keithc-ca
approved these changes
May 29, 2024
| @@ -80,7 +80,7 @@ AC_DEFUN([FLAGS_SETUP_LDFLAGS_HELPER], | |||
| BASIC_LDFLAGS_JVM_ONLY="-mno-omit-leaf-frame-pointer -mstack-alignment=16 \ | |||
| -fPIC" | |||
| if test "x$OPENJDK_TARGET_OS" = xaix; then | |||
| BASIC_LDFLAGS="-Wl,-b64 -Wl,-brtl -Wl,-bnorwexec -Wl,-bnolibpath -Wl,-bnoexpall \ | |||
| BASIC_LDFLAGS="-Wl,-b64 -Wl,-brtl -Wl,-bnolibpath -Wl,-bnoexpall \ | |||
There was a problem hiding this comment.
We don't use clang on AIX, so this should make any difference (yet?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-level: this linker option is oxymoronic with JIT environment (where executable code are generated on the fly anyway).
At least for the time being before we figured out why default codeCache is allocated through malloc (instead of mmap or shmget, for which that linker option appeared to have no effect by my tests).
Even after we figured it out eventually, it is a legitimate question what value this option provides for JIT environment.
this also has effect on FFI thunks (which are not generated in JIT codecache).
Issue #162