Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove a-label only restriction on cli, add a-label query type #55

Merged
merged 1 commit into from
Mar 7, 2024
Merged

remove a-label only restriction on cli, add a-label query type #55

merged 1 commit into from
Mar 7, 2024

Conversation

anewton1998
Copy link
Collaborator

The PR does the following:

  • Removes the restriction that CLI domain lookups must be a-labels.
  • Adds a specific query type for converting u-labels to a-labels and doing the query as an a-label
  • Adds punctuation check to the is_unicode_name string utility function

@anewton1998 anewton1998 merged commit c349937 into dev Mar 7, 2024
2 checks passed
@anewton1998 anewton1998 mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anewton1998