Skip to content

Commit

Permalink
make: Using ${} for function in 1st argument of ifneq causes error; s…
Browse files Browse the repository at this point in the history
…eems like GNU make bug. Move it to 2nd argument.
  • Loading branch information
mgates3 committed May 28, 2024
1 parent b19a2bb commit 89983aa
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ifeq (${MAKECMDGOALS},config)
config: make.inc

make.inc: force
else ifneq ($(findstring clean,${MAKECMDGOALS}),clean)
else ifneq (clean,${findstring clean,${MAKECMDGOALS}})
# For `make clean` or `make distclean`, don't include make.inc,
# which could generate it. Otherwise, include make.inc.
include make.inc
Expand Down Expand Up @@ -67,7 +67,7 @@ ldflags_shared = -shared
# auto-detect OS
# $OSTYPE may not be exported from the shell, so echo it
ostype := ${shell echo $${OSTYPE}}
ifneq ($(findstring darwin, ${ostype}),)
ifneq (,${findstring darwin, ${ostype}})
# MacOS is darwin
macos = 1
# MacOS needs shared library's path set, and shared library version.
Expand Down

0 comments on commit 89983aa

Please sign in to comment.