unit_test: test norm with small tile to avoid old LAPACK inaccuracy bug

icl-utk-edu · May 31, 2024 · 6d897e1 · 6d897e1
1 parent 1c4e90a
commit 6d897e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/unit_test/test_norm.cc b/unit_test/test_norm.cc
@@ -154,8 +154,8 @@ void test_genorm_dev(Norm norm)
     }
 
     double eps = std::numeric_limits<double>::epsilon();
-    int m = 3000;
-    int n = 3000;
+    int m = 20;
+    int n = 30;
     int lda = roundup(m, 8);
     double* Adata = new double[ lda * n ];
     slate::Tile<double> A(m, n, Adata, lda, -1, slate::TileKind::UserOwned);
@@ -374,7 +374,11 @@ void test_synorm_dev(Norm norm, Uplo uplo)
     }
 
     double eps = std::numeric_limits<double>::epsilon();
-    int n = 3000;
+
+    // Note: if testing with large n, some LAPACK versions have an
+    // inaccurate Frobenius lansy. If problems are encountered,
+    // verify with reference LAPACK >= v3.10.0.
+    int n = 30;
     int lda = roundup(n, 8);
     double* Adata = new double[ lda * n ];
     slate::Tile<double> A(n, n, Adata, lda, -1, slate::TileKind::UserOwned);

diff --git a/unit_test/unit_test.cc b/unit_test/unit_test.cc
@@ -122,7 +122,7 @@ std::string output_fail( AssertError const& ex )
 std::string output_skip( SkipException const& ex )
 {
     return std::string( ansi_magenta ) + "skipped: " + ansi_normal
-            + ansi_gray + ex.what() + ansi_normal + "\n";
+            + ansi_gray + ex.what() + ansi_normal;
 }
 
 //------------------------------------------------------------------------------