Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tile life from ge2tb and he2hb #123

Merged
merged 10 commits into from
Nov 16, 2023

Conversation

neil-lindquist
Copy link
Contributor

@neil-lindquist neil-lindquist commented Oct 4, 2023

This puts a good dent into #119 (especially since I also addressed some of the unrelated BLAS routines).

I also did some related cleanup:

  • In ge2tb, only store the tiles of VT for the short time we use them (reducing the total memory footprint of values-only svd)
  • De-duplicate the logic to compute the first indices into helper functions

@neil-lindquist neil-lindquist force-pushed the neil/svd-tile-life branch 4 times, most recently from 3983fa0 to de32d99 Compare October 5, 2023 17:41
@neil-lindquist neil-lindquist marked this pull request as ready for review October 27, 2023 15:10
@neil-lindquist neil-lindquist changed the title Remove tile life from ge2tb and he2hb (Depends on #117) Remove tile life from ge2tb and he2hb Oct 27, 2023
Copy link
Collaborator

@mgates3 mgates3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes me so happy.

src/ge2tb.cc Show resolved Hide resolved
src/ge2tb.cc Show resolved Hide resolved
src/ge2tb.cc Show resolved Hide resolved
src/internal/internal_util.hh Outdated Show resolved Hide resolved
src/internal/internal_util.hh Outdated Show resolved Hide resolved
src/internal/internal_util.hh Outdated Show resolved Hide resolved
src/internal/internal_util.hh Outdated Show resolved Hide resolved
src/he2hb.cc Show resolved Hide resolved
@neil-lindquist neil-lindquist merged commit 75c3ba1 into icl-utk-edu:master Nov 16, 2023
8 checks passed
@neil-lindquist neil-lindquist deleted the neil/svd-tile-life branch November 16, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants