Arbitrary regions in device set #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgates3
approved these changes
Oct 19, 2023
neil-lindquist
force-pushed
the
neil/regions-set
branch
from
3cf14ab to
791135c
Compare
cayrols
reviewed
Oct 19, 2023
cayrols
reviewed
Oct 19, 2023
cayrols
reviewed
Oct 19, 2023
Comment on lines
+173
to
177
| else { | ||
| assert( group.mb == Aij.mb() ); | ||
| assert( group.nb == Aij.nb() ); | ||
| assert( group.lda == Aij.stride() ); | ||
| } |
There was a problem hiding this comment.
Is this piece of code needed? The way I understand it is more we do not trust enough the irange and jrage, correct?
There was a problem hiding this comment.
The checks on mb and nb are probably unnecessary, yea. I'll look at removing them. The check on lda could come into play if users are providing memory themselves and have inconsistent strides. It's maybe not a case that will actually arise, but assertions are nicer to debug if it does.
There was a problem hiding this comment.
They're asserts to ensure the program logic is correct. If compiled with -DNDEBUG, they disappear. I would leave them, though maybe they don't need to go into every function that gets regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets Bitbucket PR 202 working and applies it to
tzset.I plan to make a similar extension to other routines too, but I wanted to get feedback before re-writing too many routines.