-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Additional Internal Timers for SLATE Routines #136
Conversation
@mgates3 I have started adding additional internal timers for the routines outlined in issue #128. I have currently pushed up four, but only three I believe are ready for review which are: |
At line 242 within
We run into calls again for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first step. See changes in posv_mixed_gmres. Similar changes need to apply to posv_mixed, gesv_mixed, gesv_mixed_gmres.
This was my first pass. I might have other suggestions later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more changes. Make sure same changes are applied to both gesv
and posv
. Sometimes I use meld to compare files; may or may not be useful.
meld src/posv_mixed.cc src/gesv_mixed.cc
I will resolve the branch conflicts tomorrow, but I just want to comment that I do indeed see them. As well, as do another pass to make sure everything is correctly in order. |
…l timers for gesv_mixed.
…, posv_mixed_gmres, gbsv, gels, gesv, hesv, and posv.
2551966
to
86bb586
Compare
This PR will address adding additional internal timers for the following SLATE routines:
See issue #128.