-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tile life from remaining routines #150
Remove tile life from remaining routines #150
Conversation
c349ba8
to
50c8342
Compare
50c8342
to
5d61b0b
Compare
5d61b0b
to
6c90ba4
Compare
Basci unit tests for releaseRemoteWorkspace were also added
6c90ba4
to
78b5fc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: In the newly added release tasks you sometimes use in
and sometimes inout
for dependencies. Given that you are usually changing (freeing) data, shouldn't inout
be the norm?
#pragma omp task depend(in:row[k])
#pragma omp task depend(inout:row[k])
The cases I used |
This PR removes tile life from the remaining routines. This doesn't do the big refactor to actually remove the tile life infrastructure, so that the review can focus on the logic for memory management.
A notable change is that I extended the
releaseRemoteWorkspace
functions to reduce multiple receive counts simultaneously, so I can get a little extra parallelism out ofhbmm
.