Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #190

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Cleanup #190

merged 5 commits into from
Jun 26, 2024

Conversation

mgates3
Copy link
Collaborator

@mgates3 mgates3 commented Jun 26, 2024

Various cleanup tasks

  • Replace deprecated lapy[23] with std::hypot
  • Normalize spelling of safe_min and safe_max
  • Update QR panel to match LAPACK larfg, which fixes tests with --matrix rand_small (see below)
  • Fix make clean

Abbreviated output:

pangolin slate/test> ./tester --matrix rand,rand_ufl,rand_small,rand_large,rand_ofl geqrf
% SLATE version 2024.05.31, id 4ff661ab
% input: ./tester --matrix rand,rand_ufl,rand_small,rand_large,rand_ofl geqrf
% 2024-06-26 13:06:17, 1 MPI ranks, CPU-only MPI, 4 OpenMP threads per MPI rank

type   A    m    n     error  status
   d   1  500  500  5.23e-18  pass      # rand
   d   2  500  500  1.88e-03  FAILED    # rand_ufl
   d   3  500  500  1.92e-03  FAILED    # rand_small
   d   4  500  500  5.01e-18  pass      # rand_large
   d   5  500  500       nan  FAILED    # rand_ofl

% 3 tests FAILED: geqrf


pangolin slate/test> ./tester --matrix rand,rand_ufl,rand_small,rand_large,rand_ofl geqrf
% SLATE version 2024.05.31, id 57174564
% input: ./tester --matrix rand,rand_ufl,rand_small,rand_large,rand_ofl geqrf
% 2024-06-26 13:06:57, 1 MPI ranks, CPU-only MPI, 4 OpenMP threads per MPI rank

type   A    m    n     error  status
   d   1  500  500  4.93e-18  pass      # rand
   d   2  500  500  1.90e-03  FAILED    # rand_ufl
   d   3  500  500  5.00e-18  pass      # rand_small FIXED!
   d   4  500  500  4.59e-18  pass      # rand_large
   d   5  500  500       nan  FAILED    # rand_ofl

% Matrix kinds:
%  1: rand, cond unknown
%  2: rand_ufl, cond unknown
%  3: rand_small, cond unknown
%  4: rand_large, cond unknown
%  5: rand_ofl, cond unknown

% 2 tests FAILED: geqrf

Copy link
Collaborator Author

@mgates3 mgates3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self reviewed.

@mgates3 mgates3 merged commit 73f2ad2 into icl-utk-edu:master Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant