Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Norm test code #192

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Norm test code #192

merged 7 commits into from
Jul 8, 2024

Conversation

mgates3
Copy link
Collaborator

@mgates3 mgates3 commented Jun 30, 2024

Merge 4 norm test codes into one code by templating matrix_type. Cf. test_add.cc.

scalapack_ilcm is replaced with std::lcm.

@mgates3 mgates3 mentioned this pull request Jun 30, 2024
Merged
@mgates3
Copy link
Collaborator Author

mgates3 commented Jun 30, 2024

getri failed with out-of-range exception (i.e., tile missing), which is a little weird because this PR doesn't deal with getri. May be race condition revealed by recently merged #48.

mgates3
mgates3 commented Jul 7, 2024
View reviewed changes
Copy link
Collaborator Author

@mgates3 mgates3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

include/slate/internal/util.hh Show resolved Hide resolved
include/slate/internal/util.hh Show resolved Hide resolved
include/slate/internal/util.hh Show resolved Hide resolved
src/cuda/device_genorm.cu Show resolved Hide resolved
src/cuda/device_util.cuh Show resolved Hide resolved
@mgates3 mgates3 merged commit d47e9d6 into icl-utk-edu:master Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgates3