Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2025-04-28-vit-baseline-revisited #37

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

2025-04-28-vit-baseline-revisited #37

wants to merge 26 commits into from

Conversation

EIFY
Copy link

@EIFY EIFY commented Nov 15, 2024 •
edited
Loading

OpenReview Submission Thread

https://openreview.net/forum?id=0ylzRb6MBa&noteId=0ylzRb6MBa

Checklist before opening a PR

  • I am opening a pull request against the main branch of the 2025 repo.
  • The title of my PR is exactly the name of my markdown file
    • i.e. _posts/2025-04-28-[SUBMISSION NAME].md would require a PR name 2025-04-28-[SUBMISSION NAME]
  • I have anonymized my post: my author's list is Anonymous, and there is no potential
    content which can reveal my/my collaborators identities.
  • My post matches the formatting requirements, including (but not limited to):
    • I have ONLY MODIFIED files in the following locations (failure to do so will result in
      your PR automatically being closed!):
      • a Markdown (or HTML) file in _posts/ with the format _posts/2025-04-28-[SUBMISSION NAME].md (or .html)
      • static image assets added to assets/img/2025-04-28-[SUBMISSION NAME]/
      • interactive HTML figures added to assets/html/2025-04-28-[SUBMISSION NAME]/
      • citations in a bibtex file in assets/bibliography/2025-04-28-[SUBMISSION NAME].bib
    • I have a short 2-3 sentence abstract in the description field of my front-matter
    • I have a table of contents, formatted using the toc field of my front-matter
    • My bibliography is correctly formatted, using a .bibtex file as per the sample post

Any other comments

@EIFY
Copy link
Author

EIFY commented Nov 16, 2024

@busycalibrating Hi - I just synced my branch. Do you have to manually trigger the pipeline to generate the review link?

Also while we are at it - could you take a look at my (non-submission) PR? Thx.
#12

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@EIFY
Copy link
Author

EIFY commented Nov 16, 2024

@busycalibrating Interestingly my references are fine. Just not the image assets... 🤔

@busycalibrating
Copy link
Member

busycalibrating commented Nov 16, 2024 •
edited
Loading

Can you verify you have the correct syntax to specify the paths? I've confirmed that my sample post renders correctly, you can check here: #31
And the blog itself is here

@EIFY
Copy link
Author

EIFY commented Nov 16, 2024 •
edited
Loading

@busycalibrating Alright, so I have been doing this to center the images instead of using iframe:

<div class="caption">
  <img src="/2025/assets/img/2025-04-28-vit-baseline-revisited/gradient_L2_norm_comparison.png" class="img-fluid" width="auto" height="auto">
</div>

which works locally but not for the review url. Let me see if I can search & replace them...

@busycalibrating
Copy link
Member

You have an extra /2025 prefixing your img_src that I don't believe should be there, maybe check that?

@busycalibrating
Copy link
Member

Your links seem to look like this:

https://d2jud02ci9yv69.cloudfront.net/2025/assets/img/2025-04-28-vit-baseline-revisited/gradient_L2_norm_comparison.png

when they should look like this:

https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/assets/img/2025-04-28-vit-baseline-revisited/gradient_L2_norm_comparison.png

@EIFY
Copy link
Author

EIFY commented Nov 16, 2024

I figured out as much but that 2025-04-28-vit-baseline-revisited-37/ part is generated that I have no control over.
Let me see if I really have to abandon the use of <img src="(...)">...

@busycalibrating
Copy link
Member

Alright let me know if there's something on my end you need me to take a look at!

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@EIFY
Copy link
Author

EIFY commented Nov 16, 2024

@busycalibrating FYI I fixed it! It just requires some Jekyll Liquid filter magic

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@EIFY
citation count descending order
aefb87c 
It's almost in descending order already, so might as well make it so.
@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2025-04-28-vit-baseline-revisited-37/blog/vit-baseline-revisited/ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EIFY @busycalibrating