move some constants strings to config (#152)

icpc · Mar 6, 2024 · 635ee46 · 635ee46
1 parent 7a0900f
commit 635ee46
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/frontend/overlay/src/components/organisms/widgets/Scoreboard.tsx b/src/frontend/overlay/src/components/organisms/widgets/Scoreboard.tsx
@@ -59,9 +59,9 @@ const ScoreboardContent = styled.div`
 
 
 export const nameTable = {
-    normal: "Current",
-    optimistic: "Optimistic",
-    pessimistic: "Pessimistic",
+    normal: c.SCOREBOARD_NORMAL_NAME,
+    optimistic: c.SCOREBOARD_OPTIMISTIC_NAME,
+    pessimistic: c.SCOREBOARD_PESSIMISTIC_NAME,
 };
 
 const ScoreboardTableRowWrap = styled.div<{needPenalty: boolean, nProblems: number}>`
@@ -287,7 +287,7 @@ export const Scoreboard = ({ widgetData: { settings } }) => {
     return <ScoreboardWrap>
         <ScoreboardHeader>
             <ScoreboardTitle>
-                {nameTable[settings.optimismLevel] ?? "??"} standings
+                {nameTable[settings.optimismLevel] ?? c.SCOREBOARD_UNDEFINED_NAME} standings
             </ScoreboardTitle>
             <ScoreboardCaption>
                 {c.SCOREBOARD_CAPTION}

diff --git a/src/frontend/overlay/src/config.ts b/src/frontend/overlay/src/config.ts
@@ -98,6 +98,11 @@ config.SCOREBOARD_CELL_POINTS_ALIGN = "center";
 config.SCOREBOARD_CELL_PENALTY_SIZE = "92px";
 config.SCOREBOARD_CELL_PENALTY_ALIGN = "center";
 
+config.SCOREBOARD_NORMAL_NAME = "Current";
+config.SCOREBOARD_OPTIMISTIC_NAME = "Optimistic";
+config.SCOREBOARD_PESSIMISTIC_NAME = "Pessimistic";
+config.SCOREBUARD_UNDEFINED_NAME = "??";
+
 
 config.QUEUE_ROW_FONT_SIZE = config.GLOBAL_DEFAULT_FONT_SIZE;
 config.QUEUE_ROW_BACKGROUND = "rgba(0, 0, 0, 0.08)";