Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal for handling regexps. #163

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Add proposal for handling regexps. #163

merged 4 commits into from
Mar 7, 2022

Conversation

cabo
Copy link
Member

@cabo cabo commented Mar 7, 2022

Close #70

@cabo cabo requested review from timbray, glyn and goessner March 7, 2022 14:15
Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. I suggested a few improvements.

draft-ietf-jsonpath-base.md Outdated Show resolved Hide resolved
draft-ietf-jsonpath-base.md Show resolved Hide resolved
side of `=~` are as defined in {{-iregexp}}.
Regular expression tests can be applied to JSON string values
({{Section 7 of -json}}) only
(left-hand side of `=~`).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when there is a path on the LHS which does not identify a string? I presume the regex result is false, but the spec needs to be explicit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. See
d674175

Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now with the most recent changes. Thanks.

@cabo cabo merged commit 683d491 into main Mar 7, 2022
@cabo
Copy link
Member Author

cabo commented Mar 7, 2022

Anything else we expect to merge for this I-D deadline?
If not, I'd like to submit.

@goessner
Copy link
Collaborator

goessner commented Mar 7, 2022

great ,,, thanks.

@cabo cabo deleted the regexp branch March 16, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regular expressions in filters
3 participants