-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal for handling regexps. #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this. I suggested a few improvements.
draft-ietf-jsonpath-base.md
Outdated
side of `=~` are as defined in {{-iregexp}}. | ||
Regular expression tests can be applied to JSON string values | ||
({{Section 7 of -json}}) only | ||
(left-hand side of `=~`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when there is a path on the LHS which does not identify a string? I presume the regex result is false
, but the spec needs to be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. See
d674175
Co-authored-by: Glyn Normington <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now with the most recent changes. Thanks.
Anything else we expect to merge for this I-D deadline? |
great ,,, thanks. |
Close #70