Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getDisplacementFunction #223

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

tarun-mitruka
Copy link
Collaborator

@tarun-mitruka tarun-mitruka commented Jan 4, 2024

This PR was split from #221. See #221 for some PR review comments.

!!! UPDATE
std::optional version in finite elements has to be removed and the if-else branch in localSolutionBlockVector has to be determined during compile time. This will be addressed in #228

@tarun-mitruka tarun-mitruka self-assigned this Jan 4, 2024
@tarun-mitruka tarun-mitruka added the refactor Refactor code for readability label Jan 4, 2024
@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch from c9ae5fb to 4299a23 Compare January 4, 2024 10:45
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dfc766) 92.87% compared to head (a216aef) 92.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   92.87%   92.73%   -0.15%     
==========================================
  Files          49       50       +1     
  Lines        2022     1982      -40     
==========================================
- Hits         1878     1838      -40     
  Misses        144      144              
Flag Coverage Δ
tests 92.73% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch 6 times, most recently from 7572255 to 9a48bac Compare January 9, 2024 08:34
@tarun-mitruka tarun-mitruka marked this pull request as ready for review January 9, 2024 10:20
@tarun-mitruka tarun-mitruka requested a review from rath3t January 9, 2024 10:20
Copy link
Collaborator

@rath3t rath3t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch from 1693736 to 04756f6 Compare January 9, 2024 12:37
@tarun-mitruka tarun-mitruka requested a review from rath3t January 9, 2024 14:35
@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch 4 times, most recently from 0633805 to e44f234 Compare January 10, 2024 12:03
@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch 3 times, most recently from b8a9ec2 to 746cb55 Compare January 10, 2024 16:01
@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch from ea093d1 to c6be226 Compare January 10, 2024 17:20
@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch from c6be226 to 453123d Compare January 10, 2024 17:21
Copy link
Collaborator

@rath3t rath3t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look into these minor things.
Than we can merge. Thanks Tarun!

@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch from 57a7914 to 0dc07b1 Compare January 17, 2024 11:37
@tarun-mitruka tarun-mitruka force-pushed the refactor/getDisplacementFunction branch from 0dc07b1 to a216aef Compare January 17, 2024 11:48
@rath3t rath3t enabled auto-merge (squash) January 17, 2024 11:53
@rath3t rath3t merged commit cca5ed0 into main Jan 17, 2024
17 of 18 checks passed
@tarun-mitruka tarun-mitruka deleted the refactor/getDisplacementFunction branch January 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code for readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a wrapper for the optional variable needed for AutoDiff to avoid duplication of code
2 participants