-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor getDisplacementFunction #223
Conversation
c9ae5fb
to
4299a23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 92.87% 92.73% -0.15%
==========================================
Files 49 50 +1
Lines 2022 1982 -40
==========================================
- Hits 1878 1838 -40
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7572255
to
9a48bac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
1693736
to
04756f6
Compare
0633805
to
e44f234
Compare
b8a9ec2
to
746cb55
Compare
ea093d1
to
c6be226
Compare
c6be226
to
453123d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look into these minor things.
Than we can merge. Thanks Tarun!
57a7914
to
0dc07b1
Compare
0dc07b1
to
a216aef
Compare
This PR was split from #221. See #221 for some PR review comments.
!!! UPDATE
std::optional
version in finite elements has to be removed and theif-else
branch inlocalSolutionBlockVector
has to be determined during compile time. This will be addressed in #228