-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Observer Pattern for UpdateState #346
Draft
henrij22
wants to merge
10
commits into
NonlinearEAS
Choose a base branch
from
feature/updateStateObserver
base: NonlinearEAS
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+577
−650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarun-mitruka
force-pushed
the
NonlinearEAS
branch
2 times, most recently
from
January 14, 2025 07:39
4f1ca33
to
1729aba
Compare
8 tasks
test run? test runs test runs this wont work
henrij22
force-pushed
the
feature/updateStateObserver
branch
from
January 16, 2025 15:10
39eb462
to
b26883b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## NonlinearEAS #346 +/- ##
================================================
+ Coverage 80.72% 81.29% +0.56%
================================================
Files 70 68 -2
Lines 2309 2299 -10
================================================
+ Hits 1864 1869 +5
+ Misses 445 430 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
henrij22
force-pushed
the
feature/updateStateObserver
branch
from
January 16, 2025 17:02
acb86e8
to
0f12922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be merged in Nonlinear EAS PR
I ve now got working code with https://godbolt.org/z/b9cM5e714
I implemented Broadcasters next to Observers, so there are both implementations right now.
OLD
I don't know how to get this to work without a major overhaul of the observer thing.
The problem is that i want to notify like
So now the problem is that x and correction can have a lot of different types, Eigen Vector, Matrices, SparseVectors ...
For that i subclassed IOObservable like
that works now if
has an observer that is also templated with two vectors
for example like
but that means that every observer has to be templated like that because we need in IOObservable
which then means that every derived class of IOObserver somehow needs to be convertable to that.
Now i have a problem:
doenst work because of
So i don't really know how to convert this because
takes a shared ptr to some observer with these template arguments.
Maybe you have a good idea @tarun-mitruka @rath3t
Maybe this can work out
#260