Update gems #20
Merged
Update gems #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatsmydoing
commented
Dec 4, 2023
| @@ -1,11 +1,12 @@ | |||
| with (import <nixpkgs> {}); | |||
| let | |||
| ruby = ruby_3_1; | |||
There was a problem hiding this comment.
ruby_3_0 doesn't exist in latest nixpkgs anymore and ruby_3_1 is the default ruby.
| name = "bundler-env"; | ||
| gemdir = ./nix/gem; | ||
| }; | ||
| in stdenv.mkDerivation { | ||
| name = "shell"; | ||
| buildInputs = [ env ]; | ||
| buildInputs = [ env ruby ]; |
There was a problem hiding this comment.
bundlerEnv doesn't include ruby so running commands was using system ruby instead.
thatsmydoing
force-pushed
the
update-gems
branch
from
988e175 to
84698bb
Compare
thefloweringash
approved these changes
Dec 4, 2023
chrisandreae
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the tests and they passed and did an upload / download which seems to work. I did no other checks.