Prevent parallel upload of default language #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisandreae
force-pushed
the
upload-default-language-first
branch
from
bcf9078 to
01fd6da
Compare
chrisandreae
force-pushed
the
upload-default-language-first
branch
from
01fd6da to
29e0bc9
Compare
gordoncl
approved these changes
Sep 30, 2024
Comment on lines
+109
to
+122
| if default_locale_file | ||
| unless known_locales.has_key?(default_locale_file.locale_name) | ||
| STDERR.puts("Creating default locale (#{default_locale_file})") | ||
| create_locale(default_locale_file.locale_name, default: true) | ||
| end | ||
|
|
||
| STDERR.puts("Uploading default locale (#{default_locale_file})") | ||
| upload_id = upload_file(default_locale_file) | ||
|
|
||
| successful_default_upload = verify_uploads({ upload_id => default_locale_file }) | ||
| else | ||
| STDERR.puts("No upload for default locale (#{default_locale})") | ||
| end |
There was a problem hiding this comment.
I would document this block about the motivation for separating the default locale from the other locale files.
# The default locale file is being handled separately and first. Phraseapp appears to have
# behaviors for resolving key conflicts (pluralized versus non pluralized) by using precedence.
Permitted keys of translation languages seem to depend on the default language, so upload the default language first. In addition, upload translation languages in parallel.
chrisandreae
force-pushed
the
upload-default-language-first
branch
from
4c4b036 to
9e118df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permitted keys of translation languages seem to depend on the default language, so upload the default language first. In addition, change to uploading translation languages in parallel.