0.10: add support for restricted stashes and ISAs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmari
requested changes
Feb 20, 2017
lib/Class/Unload.pm
Outdated
| =cut | ||
|
|
||
| sub unload { | ||
| my ($self, $class) = @_; | ||
|
|
||
| return unless Class::Inspector->loaded( $class ); | ||
|
|
||
| if ($class =~ /^(main|CORE|Internals|utf8|UNIVERSAL|PerlIO|re)$/) { |
There was a problem hiding this comment.
This will catch class names with trailing newlines too. Please use \A and \z instead of the ambiguous and flag-dependent ^ and $.
| #} | ||
| #elsif ($was_readonly) { | ||
| # Internals::SvREADONLY(%{$symtab}, 1); | ||
| #} |
There was a problem hiding this comment.
It's merely a policy question. So far I think it's easier to keep it unlocked to be able to inspect and call methods on the subclasses. perl5 will e.g. fail with AUTOLOAD and DESTROY methods being magically chained down from subclasses, only cperl can handle restricted stashes. See updated PR
Class::Inspector cannot handle it neither.
I'll force push to this PR.
classes can be locked and closed. handle all cases. protect internal core stashes from being deleted.
on unloaded classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classes can be locked and closed. handle all cases.
protect internal core stashes from being deleted.