Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curved step line edges #1636

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mariogrip
Copy link

This adds curved step line edges, putting this as a draft to get some feedback.

bilde

@imaNNeo
Copy link
Owner

imaNNeo commented Jan 6, 2025

Hi, thanks for your contribution. I'm sorry about my late reply.
It looks good to me,
I think we can remove isStepLineEdgesCurved property, as we can having it using our stepLineEdgesSmoothness. It can be stepLineEdgesSmoothness != 0

I think you need to rebase your branch.

Please update the bar_chart.md file to add this property,
Also don't forget to write a unit-test for your feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants