chore(server)!: default max bitrate unit to kbps #15264
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this something we need to call out in the changelog in case it's messing up someone's expected setting? |
bo0tzz
approved these changes
Jan 11, 2025
mertalev
changed the title
Good point, it counts as a breaking change since it's possible someone actually uses bytes. |
jrasm91
approved these changes
Jan 12, 2025
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Jan 13, 2025
default unit to kbps
arctic-foxtato
pushed a commit
to arctic-foxtato/immich
that referenced
this pull request
Jan 14, 2025
default unit to kbps
agross
added a commit
to agross/ansible-home-network
that referenced
this pull request
Jan 24, 2025
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
default unit to kbps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The max bitrate can be set with different units at the end. However, if no unit is provided, the default is to interpret it as bytes. This is almost definitely not what they meant; it's better to assume kbps instead.